Skip to content

Conversation

@jjotero
Copy link
Contributor

@jjotero jjotero commented Feb 24, 2021

This PR fixes the upstream propagation of changes to variables done by the child classes. Reproducer:

class Foo(rfm.RegressionMixin):
    v = variable(int, value=3)

class Bar(Foo):
    v = 4

Foo().v # Erroneously printed 4 instead of 3
Bar().v # Prints 4

A unit tests has been extended to catch this.

@jjotero jjotero added this to the ReFrame 3.5.0 milestone Feb 24, 2021
@jjotero jjotero requested a review from vkarak February 24, 2021 10:33
@jjotero jjotero self-assigned this Feb 24, 2021
@vkarak vkarak merged commit 4435332 into reframe-hpc:master Feb 24, 2021
@jjotero jjotero deleted the bugfix/deepcopy-vars branch February 24, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants