[feat] Log reference values of all performance variables in a single line #1816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also introduces a new function in the `ScopedDict` that returns all the keys in a specific scope. This is used by the logging mechanism to retrieve and log the correct references for the current system partition.
teojgo
requested changes
Feb 25, 2021
reframe/utility/__init__.py
Outdated
| for k, v in scope_dict.items(): | ||
| self.data[scope][k] = v | ||
|
|
||
| def scope(self, scope): |
Contributor
There was a problem hiding this comment.
You can mention this on line 673 where you comment on trying to retrieve whole scopes.
Codecov Report
@@ Coverage Diff @@
## master #1816 +/- ##
==========================================
+ Coverage 87.60% 87.62% +0.02%
==========================================
Files 49 49
Lines 7937 7954 +17
==========================================
+ Hits 6953 6970 +17
Misses 984 984
Continue to review full report at Codecov.
|
teojgo
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also introduces a new function in the
ScopedDictthat returns all the keys in a specific scope. This is used by the logging mechanism to retrieve and log the correct references for the current system partition.Now somebody could use
%(check_perf_patterns)sand%(check_reference)sto log all performance variables and their references in a single line.Addresses #1543.