[test] Update checks of supported applications on Pilatus

[lucamar]

Existing checks of supported applications valid on Eiger can be easily adapted to Pilatus with the following lines (e.g.: NAMD):

        if self.current_system.name == 'pilatus':
            self.valid_prog_environs = ['cpeIntel']
        else:
            self.valid_prog_environs = ['builtin']

[lucamar]

I have marked the pull request as a draft, since I will add the working checks of other supported applications here.

[lucamar]

I have provided the updated checks of selected scientific applications on Pilatus: for LAMMPS I'd rather use lmp_mpi than lmp_omp.

[lucamar]

NAMD failed the performance check on Piz Daint.

[pep8speaks]

Hello @lucamar, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2021-03-05 08:36:27 UTC

[lucamar]

I have updated the reference performance of LAMMPS on Eiger and Pilatus: we might adjust the checks after further testing.

[vkarak]

lgtm

[ekouts]

Lgtm overall, I only have a couple of comments based on the coding style guide of reframe.

[ekouts]

Suggested change

	else:
	self.valid_prog_environs = ['builtin']
	else:
	self.valid_prog_environs = ['builtin']

Please add an extra new line after the if statements

[ekouts]

Suggested change

	if self.current_system.name == 'pilatus':
	self.valid_prog_environs = ['cpeIntel']
	else:
	self.valid_prog_environs = ['builtin']
	if self.current_system.name == 'pilatus':
	self.valid_prog_environs = ['cpeIntel']
	else:
	self.valid_prog_environs = ['builtin']

Same here

[ekouts]

Ah sorry, too late 😅

[vkarak]

Oh, sorry! You are right btw in your comment, but never mind, we can fix this whenever we touch again the test file.