[test] Scalapack check: remove custom code #1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ChristopherBignamini I think you mixed up this PR with other tests. |
Contributor
Author
|
Yes, sorry...I don't know what happened, can we delete the PR? |
ChristopherBignamini
force-pushed
the
scalapack_remove_custom
branch
from
e9e789f to
115e5dd
Compare
Contributor
Author
|
No need to close, it should be ok now |
vkarak
requested changes
Mar 12, 2021
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
This is not enough we should remove the access to the resourcesdir altogether in the test by moving the original file in the test's sourcesdir.
vkarak
approved these changes
Mar 17, 2021
Contributor
|
@ChristopherBignamini Can you fix the unused import issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.