[doc] Various documentation fixes #1859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekouts
approved these changes
Mar 12, 2021
Contributor
ekouts
left a comment
ekouts
left a comment
There was a problem hiding this comment.
Lgtm overall, I am not sure if you omit the description on purpose but it can be merged as it is.
| @rfm.simple_test | ||
| class MyTest(rfm.RegressionTest): | ||
| def __init__(self, s, e, m): | ||
| self.descr = f'{s}, {e}, {m}' |
Contributor
There was a problem hiding this comment.
I am not sure if you remove the description by mistake here?
Contributor
Author
There was a problem hiding this comment.
I did it no purpose. It's not needed for what we need to show.
| @rfm.simple_test | ||
| class MyTest(rfm.RegressionTest): | ||
| def __init__(self, s, e, m): | ||
| self.descr = f'{s}, {e}, {m}' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1856.
Fixes #1858.