[feat] Add a time_limit partition configuration parameter and a build_time_limit variable for regression tests
#1860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarak
requested changes
Mar 12, 2021
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
As discussed offline, I suggest the following:
- Remove the default time limit for tests altogether.
- Add a new
time_limitpartition configuration option. - Add a new
time_limit_buildtest variable for setting the time limit of build.
* Add also the `build_time_limit` field.
|
Hello @teojgo, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-03-16 19:54:29 UTC |
teojgo
changed the title
timelimit in partition config and build_time_limit field for regression tests
vkarak
changed the title
timelimit in partition config and build_time_limit field for regression teststimelimit in partition config and build_time_limit field for regression tests
vkarak
requested changes
Mar 16, 2021
teojgo
changed the title
timelimit in partition config and build_time_limit field for regression teststime_limit in partition config and build_time_limit field for regression tests
vkarak
changed the title
time_limit in partition config and build_time_limit field for regression teststime_limit partition configuration parameter and a build_time_limit variable for regression tests
Contributor
|
@jenkins-cscs retry none |
1 similar comment
Contributor
|
@jenkins-cscs retry none |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1733