Skip to content

[feat] Allow setting the test description and executable name directly in the class body #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2021
Merged

[feat] Allow setting the test description and executable name directly in the class body #1862

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f9ab03a
Allow setting all variables from the class body
jjotero Mar 12, 2021
5dc9d93
Allow setting the executable as required
jjotero Mar 12, 2021
a38458d
Minor implementation improvements
Mar 12, 2021
765d716
Merge branch 'master' into feature/set-executable
Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions reframe/core/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
]


import contextlib
import functools
import glob
import inspect
Expand Down Expand Up @@ -243,7 +244,7 @@ def pipeline_hooks(cls):
#:
#: :type: :class:`str`
#: :default: ``self.name``
descr = variable(str)
descr = variable(str, type(None), value=None)

#: The path to the source file or source directory of the test.
#:
Expand Down Expand Up @@ -338,7 +339,7 @@ def pipeline_hooks(cls):
#:
#: :type: :class:`str`
#: :default: ``os.path.join('.', self.name)``
executable = variable(str)
executable = variable(str, type(None), value=None)

#: List of options to be passed to the :attr:`executable`.
#:
Expand Down Expand Up @@ -811,8 +812,16 @@ def _rfm_init(self, name=None, prefix=None):
if name is not None:
self.name = name

self.descr = self.name
self.executable = os.path.join('.', self.name)
# Pass if descr is a required variable.
with contextlib.suppress(AttributeError):
if self.descr is None:
self.descr = self.name

# Pass if the executable is a required variable.
with contextlib.suppress(AttributeError):
if self.executable is None:
self.executable = os.path.join('.', self.name)

self._perfvalues = {}

# Static directories of the regression check
Expand Down