-
Notifications
You must be signed in to change notification settings - Fork 117
[doc] Add -pthread to the multithreaded tutorial test
#1870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Add -pthread to the multithreaded tutorial test
#1870
Conversation
|
@jenkins-cscs retry daint |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tutorials fail for the PGI compiler, so we would need to adapt the tests for Daint and perhaps the text...
Hmm. I have not considered the pgi compiler since in the basic tutorial it uses only the gnu/clang. |
Maybe we should move the mention of the hook in the threaded test so that we can set the flags based on the environment |
|
Hello @teojgo, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-04-06 09:29:04 UTC |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we also need to add some text later on when we introduce the hooks:
Original text:
and we set them in the setflags() pipeline hook. Let’s explain what is this all about.
Proposed text:
and we set them in the setflags() pipeline hook. We have first seen the pipeline hooks in the multithreaded "Hello, World!" example, but let’s explain now what is this all about.
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #1870 +/- ##
=======================================
Coverage 87.90% 87.90%
=======================================
Files 49 49
Lines 8452 8452
=======================================
Hits 7430 7430
Misses 1022 1022 Continue to review full report at Codecov.
|
|
@jenkins-cscs retry daint |
-pthread to the multithreaded tutorial test
Fixes #1726