Skip to content

[feat] Show a preview of the standard error in cases of build failures #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 22, 2021
Merged

[feat] Show a preview of the standard error in cases of build failures #1873

merged 5 commits into from
Mar 22, 2021

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Mar 17, 2021

Fixes #1735

@teojgo teojgo added this to the ReFrame sprint 21.03.1 milestone Mar 17, 2021
@teojgo teojgo requested review from ekouts and vkarak March 17, 2021 16:07
@teojgo teojgo self-assigned this Mar 17, 2021
@pep8speaks
Copy link

pep8speaks commented Mar 17, 2021 •
edited
Loading

Hello @teojgo, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2021-03-22 16:47:09 UTC

@codecov-io
Copy link

codecov-io commented Mar 17, 2021

Codecov Report

Merging #1873 (20654a9) into master (3623af2) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

❗ Current head 20654a9 differs from pull request most recent head 0e7fd67. Consider uploading reports for the commit 0e7fd67 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1873      +/-   ##
==========================================
- Coverage   87.83%   87.81%   -0.03%     
==========================================
  Files          49       49              
  Lines        8395     8401       +6     
==========================================
+ Hits         7374     7377       +3     
- Misses       1021     1024       +3
Impacted Files Coverage Δ
reframe/core/pipeline.py 91.53% <57.14%> (-0.43%) ⬇️
reframe/core/exceptions.py 94.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3623af2...0e7fd67. Read the comment docs.

Revert changes and implement from scratch
75f82ea 
The `BuildError` gets simply an additional `prefix` argument and makes sure to
construct the right message by reading the stderr. The 10 first lines of stderr
are printed and this is hard coded. No need to be configurable.
vkarak
vkarak approved these changes Mar 20, 2021
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reimplemented it according to what we have discussed offline.

@vkarak vkarak changed the title [feat] Support previewing of build error in failure report [feat] Show a preview of the standard error in cases of build failures Mar 20, 2021
@vkarak vkarak self-assigned this Mar 22, 2021
@vkarak vkarak merged commit c253dcf into reframe-hpc:master Mar 22, 2021
@teojgo teojgo deleted the feat/preview_build_error branch May 21, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@ekouts ekouts ekouts approved these changes

Assignees

@vkarak vkarak

@teojgo teojgo

Labels

enhancement prio: normal

Projects

None yet

Milestone

ReFrame sprint 21.03.1

Development

Successfully merging this pull request may close these issues.

Print first N lines of a failed build's stderr

5 participants

@teojgo @pep8speaks @codecov-io @vkarak @ekouts