Skip to content

[bugfix] Fix bootstrap script for pip-less Python installations #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2021
Merged

[bugfix] Fix bootstrap script for pip-less Python installations #1900

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88a9bdd
Fix bootstrap script for Dom
Mar 31, 2021
048e2f8
Address PR comments
Mar 31, 2021
2b0e298
Merge branch 'master' into bugfix/fix-bootstrap-dom
Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,16 @@ fi
# Check if ensurepip is installed
$python -m ensurepip --version &> /dev/null

export PATH=$(pwd)/external/usr/bin:$PATH

# Install pip for Python 3
if [ $? -eq 0 ]; then
CMD $python -m ensurepip --root external/ --default-pip
CMD $python -m ensurepip --root $(pwd)/external/ --default-pip
fi

# ensurepip installs pip in `external/usr/` whereas the --target option installs
# ensurepip installs pip in `external/usr/` whereas the `--root` option installs
# everything under `external/`. That's why we include both in the PYTHONPATH

export PATH=$(pwd)/external/usr/bin:$PATH
export PYTHONPATH=$(pwd)/external:$(pwd)/external/usr/lib/python$pyver/site-packages:$PYTHONPATH

CMD $python -m pip install --no-cache-dir -q --upgrade pip --target=external/
Expand Down