[bugfix] Fix crash when sourcesdir is set to None in class body
#1910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed the automatic assignment of `sourcesdir` to `None` so as to avoid setting it so, in cases that the user has explicitly passed a directory that does not exist.
Codecov Report
@@ Coverage Diff @@
## master #1910 +/- ##
=======================================
Coverage 87.90% 87.90%
=======================================
Files 49 49
Lines 8451 8451
=======================================
Hits 7429 7429
Misses 1022 1022
Continue to review full report at Codecov.
|
Contributor
Author
|
@jenkins-cscs retry daint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also changed the automatic assignment of
sourcesdirtoNoneso as to avoid setting it so, in cases that the user has explicitly passed a directory that does not exist. For this one, I'm taking advantage of the default value that is being set by the variables.Fixes #1869.