Skip to content

[bugfix] Mark jobs properly as completed in PBS scheduler #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2021
Merged

[bugfix] Mark jobs properly as completed in PBS scheduler #1944

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5768ed
Mark jobs properly as completed in PBS scheduler
Apr 22, 2021
07d8f11
PBS: Assume that jobs have finished in case of exitcode == 35
Apr 22, 2021
eb1e7c1
Merge branch 'master' into bugfix/openbs-hang
May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions reframe/core/schedulers/pbs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ class _PbsJob(sched.Job):
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self._cancelled = False

# This is set by the scheduler when both the job's state is
# 'COMPLETED' and the job's stdout and stderr are written back
self._completed = False

@property
Expand Down Expand Up @@ -191,11 +194,12 @@ def poll(self, *jobs):
# If qstat cannot find any of the job IDs, it will return 153.
# Otherwise, it will return with return code 0 and print information
# only for the jobs it could find.
if completed.returncode == 153:
self.log('Return code is 153: jobids not known by scheduler, '
'assuming all jobs completed')
if completed.returncode in (153, 35):
self.log(f'Return code is {completed.returncode}: '
f'assuming all jobs completed')
for job in jobs:
job._state = 'COMPLETED'
job._completed = True

return

Expand Down