Skip to content

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Apr 26, 2021

Fixes #1928.

@ekouts ekouts added this to the ReFrame sprint 21.04.2 milestone Apr 26, 2021
@ekouts ekouts requested review from teojgo and vkarak April 26, 2021 11:50
@ekouts ekouts self-assigned this Apr 26, 2021
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the warning should be issued by the load_all() function of the loader:

https://github.com/eth-cscs/reframe/blob/23dc03bd2b85adcae62fb69be51a047e5cef1be5/reframe/frontend/loader.py#L205-L206

@teojgo
Copy link
Contributor

teojgo commented Apr 26, 2021

I agree with @vkarak, this way you will also take into account the case where the checkpath is given by the env variable.

@ekouts
Copy link
Contributor Author

ekouts commented Apr 26, 2021

I think the warning should be issued by the load_all() function of the loader:

https://github.com/eth-cscs/reframe/blob/23dc03bd2b85adcae62fb69be51a047e5cef1be5/reframe/frontend/loader.py#L205-L206

@vkarak @teojgo What about the case that the user doesn't pass any path? Should the warning appear when he passes nothing and there is no ${RFM_INSTALL_PREFIX}/checks/? That's why I made the check earlier.

@vkarak
Copy link
Contributor

vkarak commented Apr 26, 2021

@ekouts I think the load_all() will cover that case, too. load_all() is always called to load the tests.

@ekouts
Copy link
Contributor Author

ekouts commented Apr 26, 2021

Ok, then I will change it. I thought we don't want a warning in that case.

@vkarak
Copy link
Contributor

vkarak commented Apr 26, 2021

We do want a warning there, too.

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2021

Codecov Report

Merging #1949 (e3ea0ae) into master (8b7f35e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1949   +/-   ##
=======================================
  Coverage   87.91%   87.91%           
=======================================
  Files          50       50           
  Lines        8637     8638    +1     
=======================================
+ Hits         7593     7594    +1     
  Misses       1044     1044           
Impacted Files Coverage Δ
reframe/frontend/loader.py 92.56% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b7f35e...e3ea0ae. Read the comment docs.

@vkarak vkarak changed the title [bugfix] Print a warning when search path files don't exist [bugfix] Warn when a check search path does not exist Apr 27, 2021
@vkarak vkarak merged commit d31f4f7 into reframe-hpc:master Apr 27, 2021
@ekouts ekouts deleted the bugfix/check_searchpath_files branch April 29, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReFrame does not warn or give an error if a test file does not exist

4 participants