-
Notifications
You must be signed in to change notification settings - Fork 117
[bugfix] Warn when a check search path does not exist #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Warn when a check search path does not exist #1949
Conversation
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the warning should be issued by the load_all() function of the loader:
|
I agree with @vkarak, this way you will also take into account the case where the checkpath is given by the env variable. |
|
@ekouts I think the |
|
Ok, then I will change it. I thought we don't want a warning in that case. |
|
We do want a warning there, too. |
Codecov Report
@@ Coverage Diff @@
## master #1949 +/- ##
=======================================
Coverage 87.91% 87.91%
=======================================
Files 50 50
Lines 8637 8638 +1
=======================================
+ Hits 7593 7594 +1
Misses 1044 1044
Continue to review full report at Codecov.
|
Fixes #1928.