[feat] Drop the @parameterized_test decorator
#1951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekouts
approved these changes
Apr 27, 2021
Contributor
ekouts
left a comment
ekouts
left a comment
There was a problem hiding this comment.
Looks fine to me. If we change the name from simple_test to frm_test I would deprecate in 4.0 and remove in 5.0. But I am not sure it's worth it, since it will affect literally everyone with old tests.
Should we also update the parameterized tests that use the decorator in cscs-check in a different PR? Or have a missed any open PR about this?
Contributor
Author
This should go in a different PR and be updated in the master branch, not in 4.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests should use the
parameter()built-in instead.Fixes #1833.
I don't know if we should change also the
@simple_testname to something else. And if we do, do we deprecate it from now? Or should we better deprecate@simple_testin 4.0 and remove it in 5.x?