Skip to content

[bugfix] Fixes find_modules() behaviour with flat module scheme when an environment is a substring of another one #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2021
Merged

[bugfix] Fixes find_modules() behaviour with flat module scheme when an environment is a substring of another one #1961

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1672ad
Fix https://github.com/eth-cscs/reframe/issues/1960
May 4, 2021
5746b59
Renamed environs to environ, since it the object refers to one enviro…
May 4, 2021
2ad0ace
Address PR comments
vkarak May 5, 2021
8df14c3
Merge branch 'master' into find_modules_mapping
May 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions reframe/utility/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,8 +630,8 @@ def _is_valid_for_env(m, e):
if environ_mapping is None:
return True

for patt, environs in environ_mapping.items():
if re.match(patt, m) and e in environs:
for patt, env in environ_mapping.items():
if re.match(patt, m) and e == env:
return True

return False
Expand Down