[bugfix] Fix variable and parameter access as class attributes #1988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that was causing variables and parameters set as class attributes to be silently overridden. Bug reproducer:
This PR disables setting/updating parameters when accessed as class attributes. This is because such parameter update would break the internal iterators on the parameter space. If this feature is required, explicit
insert_parameterorupdate_parameterclass methods could be added.This might be needed by #563