Skip to content

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented May 28, 2021

Addresses #1843

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

Merging #1989 (78d0414) into master (285d22f) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1989      +/-   ##
==========================================
- Coverage   86.74%   86.74%   -0.01%     
==========================================
  Files          52       52              
  Lines        9271     9269       -2     
==========================================
- Hits         8042     8040       -2     
  Misses       1229     1229              
Impacted Files Coverage Δ
reframe/core/buildsystems.py 96.33% <ø> (ø)
reframe/frontend/cli.py 75.95% <ø> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 285d22f...78d0414. Read the comment docs.

@rsarm rsarm changed the title [wip][doc] Add tutorial to show the EasyBuild build system [doc] Add tutorial to show the EasyBuild build system May 28, 2021
@rsarm rsarm marked this pull request as ready for review May 28, 2021 13:00
@rsarm
Copy link
Contributor Author

rsarm commented May 31, 2021

@jenkins-cscs retry eiger

Co-authored-by: Theofilos Manitaras <manitaras@cscs.ch>
@rsarm
Copy link
Contributor Author

rsarm commented Jun 30, 2021

@jenkins-cscs retry eiger

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only a couple of minor comments.

@rsarm
Copy link
Contributor Author

rsarm commented Jul 5, 2021

@jenkins-cscs retry dom

@rsarm
Copy link
Contributor Author

rsarm commented Jul 8, 2021

@jenkins-cscs retry daint

@vkarak vkarak changed the title [doc] Add tutorial to show the EasyBuild build system [doc] Add tutorial to showcase the use of build automation tools through ReFrame Jul 8, 2021
@vkarak vkarak requested review from jjotero, teojgo and victorusu July 8, 2021 16:35
@vkarak
Copy link
Contributor

vkarak commented Jul 9, 2021

@victorusu Can you have a look into this PR now?

Copy link
Contributor

@jjotero jjotero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak requested a review from teojgo July 9, 2021 20:55
... and remove stale prints from the frontend.
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I would only change one sentence. But this is not important.

@vkarak vkarak merged commit 9fad84c into reframe-hpc:master Jul 14, 2021
@rsarm rsarm deleted the tutorial/eb branch February 3, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants