-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Add sanity_function and deferrable builtins
#2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2007 +/- ##
==========================================
+ Coverage 87.48% 87.51% +0.02%
==========================================
Files 50 50
Lines 8853 8874 +21
==========================================
+ Hits 7745 7766 +21
Misses 1108 1108
Continue to review full report at Codecov.
|
ekouts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm in general
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just a couple of minor comments. Lgtm otherwise.
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR introduces the
sanity_functionanddeferrabledecorators, which are exposed directly in the class' namespace.The gpu microbenchmarks from the
hpctestlib(and also the job report check) have been ported to this syntax. Using this new syntax in combination with settingsanity_patternsmanually is disallowed.deferrablebuilt-in decorator exposes the same functionality as thereframe.utility.sanity.sanity_functiondecorator.reframe.utility.sanity.sanity_functionhas been marked to be deprecated in 3.8.reframe.utility.sanity.deferrable.Closes #1981
Closes #2008