Skip to content

Conversation

@casparvl
Copy link

Fixes #2009

@pep8speaks
Copy link

pep8speaks commented Jun 10, 2021

Hello @casparvl, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2021-06-10 13:37:44 UTC

@teojgo
Copy link
Contributor

teojgo commented Jun 10, 2021

Ok to test

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2021

Codecov Report

Merging #2010 (6f81368) into master (c118fec) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2010      +/-   ##
==========================================
- Coverage   87.91%   87.48%   -0.44%     
==========================================
  Files          50       50              
  Lines        8638     8850     +212     
==========================================
+ Hits         7594     7742     +148     
- Misses       1044     1108      +64     
Impacted Files Coverage Δ
reframe/frontend/statistics.py 95.95% <100.00%> (+0.50%) ⬆️
reframe/core/decorators.py 64.70% <0.00%> (-18.49%) ⬇️
reframe/core/logging.py 77.55% <0.00%> (-7.32%) ⬇️
reframe/core/hooks.py 92.78% <0.00%> (-1.82%) ⬇️
reframe/core/meta.py 98.80% <0.00%> (-1.20%) ⬇️
reframe/frontend/cli.py 75.73% <0.00%> (-0.78%) ⬇️
reframe/core/schedulers/pbs.py 47.26% <0.00%> (-0.33%) ⬇️
reframe/core/variables.py 96.03% <0.00%> (-0.02%) ⬇️
reframe/frontend/ci.py 93.33% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c118fec...6f81368. Read the comment docs.

Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teojgo teojgo merged commit dcdefb7 into reframe-hpc:master Jun 10, 2021
@jjotero
Copy link
Contributor

jjotero commented Jun 10, 2021

Thanks for the fix @casparvl !

@vkarak vkarak added this to the ReFrame Sprint 21.06.1 milestone Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in Summary of Failures

7 participants