-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Print the run report location at the end of a session #2016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @jgphpc, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-07-14 20:45:07 UTC |
ekouts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this was what @victorusu originally asked for in issue #1947. Victor maybe you can shed some light:
- I think he meant to print something like this
Rerun the failed tests using '--restore-session <report-file> -n <name1> -p <partition1> --system <system> -n <name2> -p <partition2> ...'. Or we can make it simpler with
Rerun the failed tests using '--restore-session --failed -r'. - I don't agree to print it only in the failure statistic, when we pass
--failure-stats. This is not really part of the statistics and I prefer that we print it always. What do you guys think?
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @ekouts. I don't think that this is what @victorusu requested in the corresponding issue. I interpret it as a simple line at the vey end (after the failure statistics) saying the something like "Rerun all failed tests with reframe --restore-session=report-file --failed. I personally also thing that the report-file is not needed. But @victorusu, please explain more what's your feature request is about.
Codecov Report
@@ Coverage Diff @@
## master #2016 +/- ##
=======================================
Coverage 86.74% 86.74%
=======================================
Files 52 52
Lines 9269 9270 +1
=======================================
+ Hits 8040 8041 +1
Misses 1229 1229
Continue to review full report at Codecov.
|
victorusu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
I updated this PR to print the report file always at the end of the session. I am against adding a |
Closes #1947