Skip to content

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Jun 28, 2021

Add PrgEnv-nvidia in OSU benchmark and update syntax of the tests

@ekouts ekouts added this to the ReFrame Sprint 21.06.1 milestone Jun 28, 2021
@ekouts ekouts requested review from jgphpc, jjotero and teojgo June 28, 2021 07:51
@ekouts ekouts self-assigned this Jun 28, 2021
@pep8speaks
Copy link

pep8speaks commented Jun 28, 2021

Hello @ekouts, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2021-06-28 15:32:43 UTC

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2021

Codecov Report

Merging #2040 (fc93984) into master (b8802aa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2040   +/-   ##
=======================================
  Coverage   87.48%   87.48%           
=======================================
  Files          50       50           
  Lines        8853     8853           
=======================================
  Hits         7745     7745           
  Misses       1108     1108           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8802aa...fc93984. Read the comment docs.

@reframe-hpc reframe-hpc deleted a comment from ekouts Jun 28, 2021
Copy link
Contributor

@jgphpc jgphpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jjotero
Copy link
Contributor

jjotero commented Jun 28, 2021

This should get the PEP issues fixed before merging.

@jjotero jjotero merged commit 7d2ba99 into reframe-hpc:master Jun 28, 2021
@ekouts ekouts deleted the test/osu_prgenv-nvidia branch September 3, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants