Skip to content

Conversation

@jjotero
Copy link
Contributor

@jjotero jjotero commented Jul 1, 2021

Closes #2000

@jjotero jjotero added this to the ReFrame Sprint 21.06.2 milestone Jul 1, 2021
@jjotero jjotero requested review from ekouts and vkarak July 1, 2021 09:10
@jjotero jjotero self-assigned this Jul 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2021

Codecov Report

Merging #2047 (b575714) into master (7800833) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2047      +/-   ##
==========================================
+ Coverage   87.51%   87.53%   +0.02%     
==========================================
  Files          50       50              
  Lines        8874     8889      +15     
==========================================
+ Hits         7766     7781      +15     
  Misses       1108     1108              
Impacted Files Coverage Δ
reframe/core/meta.py 98.96% <100.00%> (+0.06%) ⬆️
reframe/core/variables.py 96.09% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7800833...b575714. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jjotero jjotero merged commit ba1b53a into reframe-hpc:master Jul 1, 2021
@jjotero jjotero deleted the bugfix/hide-var-descriptor branch July 1, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

variable descriptor exposed as class attribute after the first class instantiation.

4 participants