-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Expose @final decorator in the class body
#2058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2058 +/- ##
==========================================
- Coverage 86.75% 86.75% -0.01%
==========================================
Files 52 52
Lines 9235 9240 +5
==========================================
+ Hits 8012 8016 +4
- Misses 1223 1224 +1
Continue to review full report at Codecov.
|
|
@jenkins-cscs retry daint |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. I have just a minor comment.
|
@victorusu This is needed by the |
victorusu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing we don't check in the unit tests is that a deprecation warning is thrown in case of the old syntax. I think that's why "coverage" is not very happy.
|
@jenkins-cscs retry daint |
One now can do
instead of having to use the
@rfm.finalsyntax.Other changes:
_rfm_special_testto_rfm_override_final. This flag is only used in the metaclass to allow the override of final methods, so this name is more descriptive. Also, the "special" naming of it should just be down to theRegressionTestclass.unit tests/tests_meta.pyinstead of the file with the loader tests.runstage of theRunOnlyRegressionTestwas callingsuper().run.__wrapped__(self). I've replaced this line forsuper.run()since now thefinaldecorator does not create afunctors.wrapwrapper.Closes #2001