Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Jul 15, 2021

Fixes #2072.

@vkarak vkarak added this to the ReFrame Sprint 21.07.1 milestone Jul 15, 2021
@vkarak vkarak requested review from teojgo and victorusu July 15, 2021 12:17
@vkarak vkarak self-assigned this Jul 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2021

Codecov Report

Merging #2074 (9620dd1) into master (bb91223) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2074   +/-   ##
=======================================
  Coverage   86.74%   86.74%           
=======================================
  Files          52       52           
  Lines        9270     9267    -3     
=======================================
- Hits         8041     8039    -2     
+ Misses       1229     1228    -1     
Impacted Files Coverage Δ
reframe/frontend/autodetect.py 58.46% <100.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb91223...9620dd1. Read the comment docs.

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teojgo
Copy link
Contributor

teojgo commented Jul 15, 2021

@vkarak actually now looking also the documentation, you may have to adapt also the auto-detecting part.

@vkarak vkarak merged commit f33c8e5 into reframe-hpc:master Jul 15, 2021
@vkarak vkarak deleted the bugfix/use-home-autodetect branch July 15, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReFrame crashes when trying to autodetect topology and does not have write permissions in config/_meta

4 participants