Skip to content

Conversation

@jjotero
Copy link
Contributor

@jjotero jjotero commented Jul 23, 2021

Closes #2030.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #2095 (7012ac3) into master (f55aa1c) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2095      +/-   ##
==========================================
- Coverage   86.30%   86.23%   -0.07%     
==========================================
  Files          53       53              
  Lines        9352     9305      -47     
==========================================
- Hits         8071     8024      -47     
  Misses       1281     1281              
Impacted Files Coverage Δ
reframe/core/buildsystems.py 96.10% <100.00%> (-0.24%) ⬇️
reframe/utility/typecheck.py 94.54% <0.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55aa1c...7012ac3. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [feat] Use RegressionTestMeta in the build system classes [feat] Use the built-in variable machinery in the build system classes Aug 4, 2021
@vkarak vkarak changed the title [feat] Use the built-in variable machinery in the build system classes [feat] Use the variable built-in machinery in the build system classes Aug 4, 2021
@vkarak vkarak merged commit 442e41c into reframe-hpc:master Aug 4, 2021
@jjotero jjotero deleted the feat/buildsystem-meta branch August 9, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the BuildSystem classes use the machinery from the variables.

3 participants