[bugfix] Make test_cancel_(with_grace|term_ignore) unit tests more robust
#2100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2100 +/- ##
=======================================
Coverage 86.30% 86.30%
=======================================
Files 53 53
Lines 9352 9352
=======================================
Hits 8071 8071
Misses 1281 1281 Continue to review full report at Codecov.
|
jjotero
reviewed
Jul 28, 2021
Contributor
jjotero
left a comment
jjotero
left a comment
There was a problem hiding this comment.
Since this code shows up twice in here, would it make sense to make this a function that takes anstdout and returns the sleep_pid?
vkarak
requested changes
Jul 29, 2021
jjotero
reviewed
Jul 30, 2021
Contributor
jjotero
left a comment
jjotero
left a comment
There was a problem hiding this comment.
Just a very minor comment
jjotero
suggested changes
Jul 30, 2021
Contributor
jjotero
left a comment
jjotero
left a comment
There was a problem hiding this comment.
Looks good except for that get_sleep_pid function that is defined twice.
- Move function definition closer to its use - Improve names
vkarak
approved these changes
Jul 30, 2021
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
I just did a couple of minor improvements.
vkarak
changed the title
test_cancel_(with_grace|term_ignore) more robusttest_cancel_(with_grace|term_ignore) unit tests more robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2069