Skip to content

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Jul 28, 2021

No description provided.

@rsarm rsarm added this to the ReFrame Sprint 21.07.2 milestone Jul 28, 2021
@rsarm rsarm requested review from teojgo, victorusu and vkarak July 28, 2021 15:27
@rsarm rsarm self-assigned this Jul 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2021

Codecov Report

Merging #2102 (88b4633) into master (79bedf8) will not change coverage.
The diff coverage is n/a.

❗ Current head 88b4633 differs from pull request most recent head df08a4b. Consider uploading reports for the commit df08a4b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2102   +/-   ##
=======================================
  Coverage   86.31%   86.31%           
=======================================
  Files          53       53           
  Lines        9557     9557           
=======================================
  Hits         8249     8249           
  Misses       1308     1308           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79bedf8...df08a4b. Read the comment docs.

@jgphpc jgphpc self-requested a review July 28, 2021 20:36
@@ -0,0 +1,36 @@
#
# Execute this from the top-level ReFrame source directory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Execute this from the top-level ReFrame source directory
# Execute this from the top-level ReFrame source directory
# sudo docker build -f ci-scripts/dockerfiles/tutorials.dockerfile -t rfm-tutorials:build_systems .

USER rfmuser

# Install Spack
RUN git clone https://github.com/spack/spack ~/spack && \
Copy link
Contributor

@jgphpc jgphpc Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get ==> Error: spack requires 'curl'. Make sure it is in your path.

Suggested change
RUN git clone https://github.com/spack/spack ~/spack && \
RUN useradd -ms /bin/bash rfmuser && \
apt update && \
apt install -y curl
USER rfmuser
RUN git clone https://github.com/spack/spack ~/spack && \

@jgphpc
Copy link
Contributor

jgphpc commented Aug 2, 2021

BZip2SpackCheck fails with: sanity error: pattern 'Version 1.0.6' not found in 'rfm_BZip2SpackCheck_job.err'

I understand that spack_test.py sets the version of bzip2 to load in src/myenv/spack.yaml#L3:

specs:
    - bzip2@1.0.6

Then spack env activate -V -d myenv should load what's needed but it looks like it is not found/loaded correctly.

  • Should this extra line added by ReFrame ?
spack load bzip2

(In comparison, eb_test.py#L26 adds bzip2 with: self.modules = self.build_system.generated_modules)

If not, I understand that src/myenv/spack.yaml sets the modulepath with:

lmod: spack/share/spack/lmod

but in my case (with tutorials.dockerfile), ls BZip2SpackCheck/spack/share/spack/ returns modules
Should it be lmod instead ?

What did I miss ?

@rsarm rsarm changed the title [wip][ci] Add dockerfile to run build system tutorial examples within a container [ci] Add dockerfile to run build system tutorial examples within a container Aug 17, 2021
@rsarm rsarm marked this pull request as ready for review August 17, 2021 09:14
@rsarm
Copy link
Contributor Author

rsarm commented Aug 18, 2021

@jenkins-cscs retry daint

@rsarm
Copy link
Contributor Author

rsarm commented Aug 19, 2021

@jgphpc it was wip. Now the spack load is there.

@vkarak
Copy link
Contributor

vkarak commented Aug 25, 2021

@jgphpc Can you approve this PR?

@vkarak vkarak changed the title [ci] Add dockerfile to run build system tutorial examples within a container [ci] Test run Spack and EasyBuild tutorial examples in a container Sep 7, 2021
@vkarak vkarak merged commit f20c2e9 into reframe-hpc:master Sep 7, 2021
@rsarm rsarm deleted the tutorials-docker branch February 3, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants