-
Notifications
You must be signed in to change notification settings - Fork 117
[bugfix] Fix default executable assignment
#2107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the executable is required now, you should add an executable here: https://github.com/eth-cscs/reframe/blob/8a9ceeda69619d367820d5297f5018183d52a897/unittests/test_policies.py#L139 and maybe do the same for the resources of the unittests.
Codecov Report
@@ Coverage Diff @@
## master #2107 +/- ##
==========================================
+ Coverage 86.23% 86.24% +0.01%
==========================================
Files 53 53
Lines 9305 9305
==========================================
+ Hits 8024 8025 +1
+ Misses 1281 1280 -1
Continue to review full report at Codecov.
|
|
@teojgo I think it could add that in the regression test API docs instead. Like a version changed box or something like that. |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm now. I've done a minor rephrase in the docs.
|
Is there a way to use two self.executable values in a single test? For example, if i want to run two different programs, how can i do something like self.executable1='prog1', self.executable2='prog2' with both appearing in the same submission script? This is to avoid a hack such as self.executable='prog1\nsrun prog2', which i do quite often, but is not portable. |
If you want to run to executables with the same srun options then you can put the executable commands inside a bash script |
|
@ireed You may also have a look on how to create scripts with multiple parallel launcher commands: https://reframe-hpc.readthedocs.io/en/stable/tutorial_advanced.html#adding-more-parallel-launch-commands |
RunOnlyRegressionTestclasses must be able to set theexecutablevariable asrequired. However, this variable was set a default value during class instantiation. This assignment has now been moved into thecompilestage.closes #2106