Skip to content

[test] Explicitly set the executable in the base class of the libsci_resolve test #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2021
Merged

[test] Explicitly set the executable in the base class of the libsci_resolve test #2114

merged 2 commits into from
Aug 9, 2021

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Aug 9, 2021

No description provided.

@teojgo teojgo added this to the ReFrame Sprint 21.07.2 milestone Aug 9, 2021
@teojgo teojgo requested review from jjotero and vkarak August 9, 2021 09:25
@teojgo teojgo self-assigned this Aug 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021 •
edited
Loading

Codecov Report

Merging #2114 (6a13ebf) into master (febb258) will not change coverage.
The diff coverage is n/a.

❗ Current head 6a13ebf differs from pull request most recent head 562176a. Consider uploading reports for the commit 562176a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2114   +/-   ##
=======================================
  Coverage   86.24%   86.24%           
=======================================
  Files          53       53           
  Lines        9305     9305           
=======================================
  Hits         8025     8025           
  Misses       1280     1280

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update febb258...562176a. Read the comment docs.

jjotero
jjotero reviewed Aug 9, 2021
View reviewed changes
@teojgo teojgo changed the title [test] Use name instead of executable in postbuild cmds [test] Explicitly set the executable in the base class Aug 9, 2021
@teojgo teojgo changed the title [test] Explicitly set the executable in the base class [test] Explicitly set the executable in the base class Aug 9, 2021
jjotero
jjotero approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@jjotero jjotero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [test] Explicitly set the executable in the base class [test] Explicitly set the executable in the base class of the libsci_resolve test Aug 9, 2021
@vkarak vkarak merged commit 6fd76da into reframe-hpc:master Aug 9, 2021
@teojgo teojgo deleted the test/nvidia_mkl_resolve branch August 13, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak Awaiting requested review from vkarak

1 more reviewer

@jjotero jjotero jjotero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@teojgo teojgo

Labels

bugfix prio: important

Projects

None yet

Milestone

ReFrame Sprint 21.07.2

Development

Successfully merging this pull request may close these issues.

4 participants

@teojgo @codecov-commenter @jjotero @vkarak