[bugfix] Do not crash if processor and/or device topology files are not properly formatted JSON files #2136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ekouts, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-08-23 09:37:00 UTC |
ekouts
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2136 +/- ##
==========================================
+ Coverage 85.97% 86.00% +0.03%
==========================================
Files 53 53
Lines 9362 9368 +6
==========================================
+ Hits 8049 8057 +8
+ Misses 1313 1311 -2
Continue to review full report at Codecov.
|
ekouts
changed the title
vkarak
requested changes
Aug 18, 2021
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
I also think that we can add easily a unit test to test that the auto-detection is not broken if the topology files are not valid json files.
teojgo
approved these changes
Aug 19, 2021
vkarak
approved these changes
Aug 23, 2021
vkarak
changed the title
vkarak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the processor and device files exist but cannot be loaded (empty file, invalid syntax etc), Reframe just stops and throws a throwback. With this PR we ignore the
JSONDecodeErrorand try to regenerate the file.Closes #2110.