Skip to content

Conversation

@mahendrapaipuri
Copy link
Contributor

  • This PR emits docker image name, if defined in the parent CI script, in the generated CI scripts.
  • If the user chose to increase the verbosity in the parent CI script, the child scripts will also inherit the same level of verbosity. In the current implementation, there is no verbosity and it is hard for the user to debug the test failures.
  • Tested on simple CI pipeline.

Fixes #2134

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@teojgo
Copy link
Contributor

teojgo commented Aug 18, 2021

Ok to test

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #2137 (8f5f123) into master (5dffa31) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2137      +/-   ##
==========================================
- Coverage   85.97%   85.96%   -0.01%     
==========================================
  Files          54       54              
  Lines        9644     9649       +5     
==========================================
+ Hits         8291     8295       +4     
- Misses       1353     1354       +1     
Impacted Files Coverage Δ
reframe/frontend/ci.py 91.42% <80.00%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dffa31...8f5f123. Read the comment docs.

@mahendrapaipuri
Copy link
Contributor Author

Does it sound logical to add a new configuration section for CI pipelines to define parameters like before-script, after-script, expire_in (for artifacts) so that they will be emitted in the generated yaml files?

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahendrapaipuri thanks a lot for your PR! I have just a couple of minor comments. Also we should probably document these additions somewhere in the user documentation.

@vkarak vkarak changed the title [feat] Add image name and verbosity level in CI script [feat] Parent parent CI image name and ReFrame verbosity level in the generated Gitlab child pipelines Sep 14, 2021
@vkarak vkarak changed the title [feat] Parent parent CI image name and ReFrame verbosity level in the generated Gitlab child pipelines [feat] Pass parent CI image name and ReFrame verbosity level in the generated Gitlab child pipelines Sep 14, 2021
@vkarak vkarak merged commit f7db90a into reframe-hpc:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emit image name in generated CI file

6 participants