-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Pass parent CI image name and ReFrame verbosity level in the generated Gitlab child pipelines #2137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Pass parent CI image name and ReFrame verbosity level in the generated Gitlab child pipelines #2137
Conversation
|
Can I test this patch? |
|
Ok to test |
Codecov Report
@@ Coverage Diff @@
## master #2137 +/- ##
==========================================
- Coverage 85.97% 85.96% -0.01%
==========================================
Files 54 54
Lines 9644 9649 +5
==========================================
+ Hits 8291 8295 +4
- Misses 1353 1354 +1
Continue to review full report at Codecov.
|
|
Does it sound logical to add a new configuration section for CI pipelines to define parameters like |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mahendrapaipuri thanks a lot for your PR! I have just a couple of minor comments. Also we should probably document these additions somewhere in the user documentation.
Fixes #2134