Skip to content

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Aug 19, 2021

In this PR we include the partition's and system's modules in the topology autodetecting script.

  • For local partitions we temporarily change the environment of Reframe to include both system's and partition's modules and variables.
  • For remote partitions we temporarily change the environment to include system's modules and variables and add the partition's environment in the autodetecting script.

For this PR we also added support for addition in the SequenceView and MappingView classes.

Closes #2115.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #2140 (5a3486b) into master (5b17b95) will decrease coverage by 0.00%.
The diff coverage is 68.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2140      +/-   ##
==========================================
- Coverage   86.30%   86.29%   -0.01%     
==========================================
  Files          53       53              
  Lines        9563     9571       +8     
==========================================
+ Hits         8253     8259       +6     
- Misses       1310     1312       +2     
Impacted Files Coverage Δ
reframe/frontend/autodetect.py 61.87% <60.00%> (+0.96%) ⬆️
reframe/utility/__init__.py 92.75% <83.33%> (-0.13%) ⬇️
reframe/core/schedulers/slurm.py 52.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b17b95...5a3486b. Read the comment docs.

@ekouts ekouts marked this pull request as ready for review August 23, 2021 12:10
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the description of the PR? Now you load the system modules locally, which I think is the correct thing.

@ekouts ekouts changed the title [bugfix] Include partition modules in remote partitions' autodetecting scripts [bugfix] Use partition's and system's environment when using the autodetecting feature Aug 24, 2021
@vkarak vkarak changed the title [bugfix] Use partition's and system's environment when using the autodetecting feature [bugfix] Use partition's and system's environment when autodetecting the topology Aug 25, 2021
@vkarak vkarak merged commit 78e7ce2 into reframe-hpc:master Aug 25, 2021
@ekouts ekouts deleted the bugfix/autodetect_modules branch August 25, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto detection of remote partition topology fails with launcher not found error

3 participants