-
Notifications
You must be signed in to change notification settings - Fork 117
[bugfix] Use partition's and system's environment when autodetecting the topology #2140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2140 +/- ##
==========================================
- Coverage 86.30% 86.29% -0.01%
==========================================
Files 53 53
Lines 9563 9571 +8
==========================================
+ Hits 8253 8259 +6
- Misses 1310 1312 +2
Continue to review full report at Codecov.
|
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the description of the PR? Now you load the system modules locally, which I think is the correct thing.
In this PR we include the partition's and system's modules in the topology autodetecting script.
For this PR we also added support for addition in the
SequenceViewandMappingViewclasses.Closes #2115.