-
Notifications
You must be signed in to change notification settings - Fork 117
[doc] Update tutorials to the new sanity and performance syntax #2167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2167 +/- ##
=======================================
Coverage 85.96% 85.96%
=======================================
Files 54 54
Lines 9649 9649
=======================================
Hits 8295 8295
Misses 1354 1354
Continue to review full report at Codecov.
|
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a lot of work! I have some comments for improvements and if we want to be very pedantic, we should rerun the tutorial examples and update the output wherever we list it, so that the ReFrame version in the output is meaningful.
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of additional minor comments.
| cat tutorials/basics/stream/stream4.py | ||
| .. literalinclude:: ../tutorials/basics/stream/stream3.py | ||
| .. literalinclude:: ../tutorials/basics/stream/stream4.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to git add this.
|
Looks good. Only thing remaining is to add the |
|
@vkarak I just added the missing file for the |
Closes #2082