Skip to content

Conversation

@jjotero
Copy link
Contributor

@jjotero jjotero commented Aug 30, 2021

Closes #2082

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #2167 (648d621) into master (438168b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2167   +/-   ##
=======================================
  Coverage   85.96%   85.96%           
=======================================
  Files          54       54           
  Lines        9649     9649           
=======================================
  Hits         8295     8295           
  Misses       1354     1354           
Impacted Files Coverage Δ
reframe/utility/sanity.py 97.81% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438168b...648d621. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a lot of work! I have some comments for improvements and if we want to be very pedantic, we should rerun the tutorial examples and update the output wherever we list it, so that the ReFrame version in the output is meaningful.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of additional minor comments.

cat tutorials/basics/stream/stream4.py
.. literalinclude:: ../tutorials/basics/stream/stream3.py
.. literalinclude:: ../tutorials/basics/stream/stream4.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to git add this.

@vkarak
Copy link
Contributor

vkarak commented Sep 13, 2021

Looks good. Only thing remaining is to add the stream4.py.

@jjotero
Copy link
Contributor Author

jjotero commented Sep 14, 2021

@vkarak I just added the missing file for the stream4.py tutorial. Thanks for addressing the other stuff!

@vkarak vkarak merged commit 1d33ac0 into reframe-hpc:master Sep 16, 2021
@jjotero jjotero deleted the docs/syntax branch September 18, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt the tutorial examples to use new sanity_function built-in

4 participants