[test] Add generic SPARK check for the cscs-supported apps into hpctestlib/apps #2181
Conversation
|
Hello @hurricane642, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-10-08 07:29:25 UTC |
|
Can I test this patch? |
Codecov Report
@@ Coverage Diff @@
## master #2181 +/- ##
=======================================
Coverage 85.54% 85.54%
=======================================
Files 55 55
Lines 9746 9746
=======================================
Hits 8337 8337
Misses 1409 1409 Continue to review full report at Codecov.
|
|
Ok to test |
jjotero
left a comment
jjotero
left a comment
There was a problem hiding this comment.
I'm not convinced that having a name such as base_check or so is the right approach. I think the name should be more explicit of what the test does, which in this case is computing pi. For this reason, I'd suggest that we move this "base check" to hpctestlib/apps/spark/compute_pi/__init__.py change the class names as suggested below. This would allow other people to introduce other spark checks for whatever other case they want.
| self.sanity_patterns = sn.assert_lt(sn.abs(pi_value - math.pi), 0.01) | ||
| self.maintainers = ['TM', 'RS'] | ||
| self.tags = {'production'} | ||
| class SparkCheck(Spark_BaseCheck): |
There was a problem hiding this comment.
| class SparkCheck(Spark_BaseCheck): | |
| class SparkCheck(ComputePi): |
|
@jenkins-cscs retry dom |
|
Will continue this on #2214 |
7 participants
This is a continuation of the work on the test library. This PR work has been done with SPARK tests. A new file base_check.py has been added, introducing the main class for the SPARK test, as well as the CSCS tests inherited from it.