Skip to content

[testlib] Add GROMACS benchmark tests #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Nov 29, 2021
Merged

[testlib] Add GROMACS benchmark tests #2186

merged 25 commits into from
Nov 29, 2021

Conversation

@hurricane642
Copy link
Contributor

@hurricane642 hurricane642 commented Sep 9, 2021 •
edited by vkarak
Loading

This is a continuation of the work on the test library. This PR work has been done with GROMACS tests. A new file base_check.py has been added, introducing the main class for the GROMACS test, as well as the CSCS tests inherited from it.

@pep8speaks
Copy link

pep8speaks commented Sep 9, 2021 •
edited
Loading

Hello @hurricane642, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2021-11-29 20:07:36 UTC

@jenkins-cscs
Copy link
Collaborator

jenkins-cscs commented Sep 9, 2021

Can I test this patch?

@vkarak vkarak requested review from jjotero and victorusu September 10, 2021 07:05
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021 •
edited
Loading

Codecov Report

Merging #2186 (4e91bb6) into master (c1cc49b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2186   +/-   ##
=======================================
  Coverage   86.12%   86.12%           
=======================================
  Files          56       56           
  Lines       10208    10208           
=======================================
  Hits         8792     8792           
  Misses       1416     1416

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1cc49b...4e91bb6. Read the comment docs.

@vkarak vkarak added this to the ReFrame Sprint 21.09.2 milestone Sep 28, 2021
@vkarak vkarak self-assigned this Nov 9, 2021
@vkarak vkarak changed the title [test] Add generic GROMACS check for the cscs-supported apps into hpctestlib/apps [testlib] Add generic GROMACS check for the cscs-supported apps into hpctestlib/apps Nov 9, 2021
vkarak
vkarak requested changes Nov 16, 2021
View reviewed changes
@vkarak
Copy link
Contributor

vkarak commented Nov 16, 2021

ok to test

victorusu
victorusu reviewed Nov 17, 2021
View reviewed changes
@vkarak vkarak changed the title [testlib] Add generic GROMACS check for the cscs-supported apps into hpctestlib/apps [testlib] Add Gromacs benchmarks Nov 17, 2021
@vkarak vkarak changed the title [testlib] Add Gromacs benchmarks [testlib] Add GROMACS benchmarks Nov 17, 2021
@vkarak vkarak changed the title [testlib] Add GROMACS benchmarks [testlib] Add GROMACS benchmark tests Nov 17, 2021
vkarak
vkarak requested changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments.

@vkarak
Copy link
Contributor

vkarak commented Nov 26, 2021

@victorusu We will also need to document the test properly. I will address the PR comments, but can you expand a bit on what the actual tests. An important thing is to point to the input files.

vkarak
vkarak approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done some fixes in the documentation and now it's ready to be merged.

@vkarak
Copy link
Contributor

vkarak commented Nov 29, 2021

@jenkins-cscs retry daint

@vkarak vkarak merged commit 4d918a4 into reframe-hpc:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victorusu victorusu victorusu left review comments

@vkarak vkarak vkarak approved these changes

@jjotero jjotero Awaiting requested review from jjotero

Assignees

@vkarak vkarak

@hurricane642 hurricane642

Labels

prio: normal test library

Projects

None yet

Milestone

ReFrame sprint 21.11.2

Development

Successfully merging this pull request may close these issues.

6 participants

@hurricane642 @pep8speaks @jenkins-cscs @codecov-commenter @vkarak @victorusu