Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Sep 10, 2021

If you try to auto-detect a remote partition, ReFrame will crash as follows:

Traceback (most recent call last):
  File "./bin/reframe", line 22, in <module>
    cli.main()
  File "/users/karakasv/Devel/reframe/reframe/frontend/cli.py", line 617, in main
    autodetect.detect_topology()
  File "/users/karakasv/Devel/reframe/reframe/frontend/autodetect.py", line 229, in detect_topology
    with runtime.temp_environment(modules=temp_modules,
NameError: name 'temp_modules' is not defined

This PR fixes this and introduces a unit test that tests that.

@vkarak
Copy link
Contributor Author

vkarak commented Sep 10, 2021

@jenkins-cscs retry daint

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021

Codecov Report

Merging #2189 (5b86aa4) into master (4cc8c39) will decrease coverage by 0.05%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2189      +/-   ##
==========================================
- Coverage   86.31%   86.26%   -0.06%     
==========================================
  Files          53       53              
  Lines        9557     9565       +8     
==========================================
+ Hits         8249     8251       +2     
- Misses       1308     1314       +6     
Impacted Files Coverage Δ
reframe/frontend/autodetect.py 60.40% <27.27%> (-2.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc8c39...5b86aa4. Read the comment docs.

Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I just have a small question before merging.

@vkarak vkarak merged commit 7922c5e into reframe-hpc:master Sep 13, 2021
@vkarak vkarak deleted the bugfix/remote-autodetect-crash branch September 13, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants