-
Notifications
You must be signed in to change notification settings - Fork 117
[bugfix] Fix division by zero when calculating the poll rate #2199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. I agree with printing None in the log, but I am not sure if there is something more appropriate, like 0 or inf.
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is very strange that t_elapsed can be zero! Could you reproduce that consistently?
Codecov Report
@@ Coverage Diff @@
## master #2199 +/- ##
=======================================
Coverage 85.53% 85.53%
=======================================
Files 55 55
Lines 9743 9744 +1
=======================================
+ Hits 8334 8335 +1
Misses 1409 1409
Continue to review full report at Codecov.
|
|
I think it has to do with the precision that the Laptop: Piz Daint: |
On my laptop quite often I get the error