Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Nov 1, 2021

The tutorial rewrites the OSU benchmarks using fixtures and introduces the users into the concept. I have also added a couple of figures that help visualize the fixtures in this example.

Fixes #2241.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #2257 (a2e18c1) into master (095dd68) will not change coverage.
The diff coverage is n/a.

❗ Current head a2e18c1 differs from pull request most recent head 4cb9c4d. Consider uploading reports for the commit 4cb9c4d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2257   +/-   ##
=======================================
  Coverage   86.11%   86.11%           
=======================================
  Files          56       56           
  Lines       10182    10182           
=======================================
  Hits         8768     8768           
  Misses       1414     1414           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a082ec...4cb9c4d. Read the comment docs.

Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I have some small suggestion only.

@vkarak vkarak merged commit a048a99 into reframe-hpc:master Nov 4, 2021
@vkarak vkarak deleted the doc/fixtures-tutorial branch November 4, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite dependencies tutorial example using fixtures

3 participants