Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Nov 9, 2021

I rename apps to sciapps. In the library we need to be more precise in naming things.

@vkarak vkarak added this to the ReFrame sprint 21.11.1 milestone Nov 9, 2021
@vkarak vkarak requested review from teojgo and victorusu November 9, 2021 21:28
@vkarak vkarak self-assigned this Nov 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #2260 (7c8588e) into master (c2f7e55) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2260   +/-   ##
=======================================
  Coverage   86.11%   86.11%           
=======================================
  Files          56       56           
  Lines       10182    10182           
=======================================
  Hits         8768     8768           
  Misses       1414     1414           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f7e55...7c8588e. Read the comment docs.

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 4e6665d into reframe-hpc:master Nov 10, 2021
@vkarak vkarak deleted the testlib/rename-apps branch November 10, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants