Skip to content

[feat] Filter tests based on the maintainers #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2021
Merged

[feat] Filter tests based on the maintainers #2263

merged 2 commits into from
Nov 12, 2021

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Nov 11, 2021

Closes #1980

@rsarm rsarm added this to the ReFrame sprint 21.11.1 milestone Nov 11, 2021
@rsarm rsarm requested review from teojgo and vkarak November 11, 2021 08:35
@rsarm rsarm self-assigned this Nov 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021 •
edited
Loading

Codecov Report

Merging #2263 (33efdf4) into master (4e6665d) will increase coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2263   +/-   ##
=======================================
  Coverage   86.11%   86.11%           
=======================================
  Files          56       56           
  Lines       10182    10190    +8     
=======================================
+ Hits         8768     8775    +7     
- Misses       1414     1415    +1
Impacted Files Coverage Δ
reframe/frontend/cli.py 76.25% <66.66%> (-0.06%) ⬇️
reframe/frontend/filters.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e6665d...33efdf4. Read the comment docs.

vkarak
vkarak requested changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I have just a couple of minor comments.

@vkarak
Copy link
Contributor

vkarak commented Nov 11, 2021

@jenkins-cscs retry daint

@vkarak vkarak merged commit 41b839c into reframe-hpc:master Nov 12, 2021
@rsarm rsarm deleted the filter-by-maint branch February 3, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@teojgo teojgo Awaiting requested review from teojgo

Assignees

@rsarm rsarm

Labels

prio: normal request for enhancement

Projects

None yet

Milestone

ReFrame sprint 21.11.1

Development

Successfully merging this pull request may close these issues.

Filter tests based on the maintainers

3 participants

@rsarm @codecov-commenter @vkarak