[bugfix] Fix incorrect regex for gpu_bandwidth_check perf results
#2272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string tested on is multiline, so must not match stuff with *
Codecov Report
@@ Coverage Diff @@
## master #2272 +/- ##
=======================================
Coverage 86.13% 86.13%
=======================================
Files 56 56
Lines 10202 10202
=======================================
Hits 8787 8787
Misses 1415 1415 Continue to review full report at Codecov.
|
Collaborator
|
Can I test this patch? |
Contributor
|
Ok to test |
vkarak
changed the title
Contributor
|
I have removed the |
The string tested on is multiline, so must not match stuff with *
Contributor
Author
|
Ah sorry, leftover from debugging this. And now with fix for the D2D regex too which I forgot the first time around. |
vkarak
approved these changes
Nov 20, 2021
vkarak
changed the title
gpu_bandwidth_check perf results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string tested on is multiline, so must not match stuff with *