[test] Update method to get compilation time in HelloWorldTests
#2288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2288 +/- ##
=======================================
Coverage 86.12% 86.12%
=======================================
Files 56 56
Lines 10206 10206
=======================================
Hits 8790 8790
Misses 1416 1416 Continue to review full report at Codecov.
|
teojgo
requested changes
Nov 25, 2021
teojgo
approved these changes
Nov 25, 2021
Contributor
Author
|
As a reference I run both the old and new references and there is a significant reduction in compilation times: The reference (60seconds) was already too high, I don't know if there is a point of updating it. |
vkarak
requested changes
Nov 26, 2021
vkarak
approved these changes
Nov 29, 2021
vkarak
changed the title
HelloWorldTests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this PR before merging #2194, since it brakes all the old helloworld tests. This is anyway a more reliable way to get the compilation time since it emits some commands in the build script and it doesn't include ReFrame's overhead in the compilation phase.