Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Nov 26, 2021

Fixes #2270

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #2295 (25bde13) into master (c1cc49b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2295   +/-   ##
=======================================
  Coverage   86.12%   86.12%           
=======================================
  Files          56       56           
  Lines       10208    10208           
=======================================
  Hits         8792     8792           
  Misses       1416     1416           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1cc49b...25bde13. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor changes.

@pep8speaks
Copy link

pep8speaks commented Nov 29, 2021

Hello @teojgo, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2021-11-29 16:55:25 UTC

@teojgo
Copy link
Contributor Author

teojgo commented Nov 29, 2021

@jenkins-cscs retry all

@vkarak
Copy link
Contributor

vkarak commented Nov 29, 2021

I will merge this, but perhaps we should consider including the stream.c directly in the benchmark's source instead of downloading.

@vkarak vkarak merged commit 3403570 into reframe-hpc:master Nov 29, 2021
@teojgo teojgo deleted the doc/literal_include_tagged branch December 21, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revisit the literalinclude directives in the documentation

5 participants