[testlib] Append to executable_opts in Gromacs library test
#2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2316 +/- ##
=======================================
Coverage 86.12% 86.12%
=======================================
Files 56 56
Lines 10208 10208
=======================================
Hits 8792 8792
Misses 1416 1416 Continue to review full report at Codecov.
|
vkarak
changed the title
vkarak
approved these changes
Dec 6, 2021
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
I'm not sure that this is a bug of the library or of the test that uses the library. Generally, we should answer the question: what assumptions should the library make and what the test?
vkarak
changed the title
executable_opts in Gromacs library test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
executable_optspassed by the tests are overwritten by the library-defined ones. e.g.For the CSCS checks, instead of generating these command-line options for GROMACs
one gets
This PR fixes this issue.