Skip to content

[testlib] Time the warmup phase and print minimum required duration in the GPU burn test #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2022
Merged

[testlib] Time the warmup phase and print minimum required duration in the GPU burn test #2345

merged 2 commits into from
Mar 30, 2022

Conversation

@akesandgren
Copy link
Contributor

@akesandgren akesandgren commented Dec 14, 2021 •
edited
Loading

  • Calculates the time it takes to run compare+getErrors and removes that
    during Performance calculation.
  • Read device temp values after each repetition and save maxtemp.
  • Error out if duration was too short and it didn't complete a single
    repetition.
  • Use high_resolution_clock instead of system_clock

@akesandgren
gpu_burn.cu: Time the warmup phase and print minimum required duration.
6bb573f 
 - Calculates the time it takes to run compare+getErrors and removes that
   during Performance calculation.
 - Read device temp values after each repetition and save maxtemp.
 - Error out if duration was too short and it didn't complete a single
   repetition.
@akesandgren
Copy link
Contributor Author

akesandgren commented Dec 14, 2021

This is a better rewrite than my previous attempt.

@jenkins-cscs
Copy link
Collaborator

jenkins-cscs commented Dec 14, 2021

Can I test this patch?

@vkarak vkarak requested review from ekouts and vkarak December 14, 2021 17:47
@vkarak vkarak requested a review from jjotero December 14, 2021 17:48
@vkarak vkarak added this to the ReFrame sprint 22.01.1 milestone Jan 10, 2022
@vkarak vkarak changed the title gpu_burn.cu: Time the warmup phase and print minimum required duration. [testlib] gpu_burn.cu: Time the warmup phase and print minimum required duration. Jan 10, 2022
@vkarak vkarak removed this from the ReFrame sprint 22.01.1 milestone Jan 19, 2022
@victorusu
Copy link
Contributor

victorusu commented Feb 21, 2022

Ok to test

@vkarak vkarak changed the title [testlib] gpu_burn.cu: Time the warmup phase and print minimum required duration. [testlib] Time the warmup phase and print minimum required duration in the GPU burn test Mar 29, 2022
@vkarak vkarak added this to the ReFrame Sprint 22.03.2 milestone Mar 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022 •
edited
Loading

Codecov Report

Merging #2345 (1f90628) into master (e07b494) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2345   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files          57       57           
  Lines       10546    10546           
=======================================
  Hits         9039     9039           
  Misses       1507     1507

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07b494...1f90628. Read the comment docs.

@vkarak
Copy link
Contributor

vkarak commented Mar 29, 2022

@jenkins-cscs retry daint

@vkarak vkarak merged commit d476c21 into reframe-hpc:master Mar 30, 2022
@akesandgren akesandgren deleted the gpu_burn_update branch March 30, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@ekouts ekouts Awaiting requested review from ekouts

@jjotero jjotero Awaiting requested review from jjotero

Assignees

@akesandgren akesandgren

Labels

enhancement test library

Projects

None yet

Milestone

ReFrame Sprint 22.03.2

Development

Successfully merging this pull request may close these issues.

5 participants

@akesandgren @jenkins-cscs @victorusu @codecov-commenter @vkarak