Skip to content

[test ] Update syntax of VASP check #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 20, 2021
Merged

[test ] Update syntax of VASP check #2351

merged 3 commits into from
Dec 20, 2021

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Dec 16, 2021

No description provided.

@rsarm rsarm added this to the ReFrame sprint 21.12.1 milestone Dec 16, 2021
@rsarm rsarm requested review from ekouts and vkarak December 16, 2021 08:41
@rsarm rsarm self-assigned this Dec 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021 •
edited
Loading

Codecov Report

Merging #2351 (4e6e0f7) into master (c79d952) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2351   +/-   ##
=======================================
  Coverage   86.14%   86.14%           
=======================================
  Files          56       56           
  Lines       10225    10225           
=======================================
  Hits         8808     8808           
  Misses       1417     1417

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79d952...4e6e0f7. Read the comment docs.

vkarak
vkarak approved these changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. In the future, we should consider using a single test (without inheritance) and an additional parameter.

@vkarak vkarak merged commit c5bb6ab into reframe-hpc:master Dec 20, 2021
@rsarm rsarm deleted the update-syntax/vasp branch February 3, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@ekouts ekouts ekouts approved these changes

Assignees

@rsarm rsarm

Labels

prio: normal

Projects

None yet

Milestone

ReFrame sprint 21.12.1

Development

Successfully merging this pull request may close these issues.

4 participants

@rsarm @codecov-commenter @vkarak @ekouts