Skip to content

Conversation

@ebirn
Copy link
Contributor

@ebirn ebirn commented Jan 6, 2022

Motivation: We have a bunch of RTX6000 devices at our site, which have a large difference in float vs double performance. For others like V100, P100 the TF/s difference is roughly 2x.

The changes to get the sgemm executable compiled:

  • template the dgemm gpu test code to allow execution of both Dgemm and Sgemm.
  • the makefiles are modified to define the codepaths through defines (float or double) and produce 2 executables

Note: I was not able to test the makefile.hip , so at this point I'm just assuming it will work

Question: if this is to be accepted, should the 'dgemm' directory be renamed, along with the Dgemm base test?

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@vkarak
Copy link
Contributor

vkarak commented Jan 10, 2022

ok to test

@codecov-commenter
Copy link

Codecov Report

Merging #2372 (5a4d680) into master (eddf0b2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2372   +/-   ##
=======================================
  Coverage   86.14%   86.14%           
=======================================
  Files          56       56           
  Lines       10225    10225           
=======================================
  Hits         8808     8808           
  Misses       1417     1417           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eddf0b2...5a4d680. Read the comment docs.

@vkarak vkarak removed this from the ReFrame sprint 22.01.1 milestone Jan 19, 2022
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this PR as is. For the moment, I would wait for adapting the test to build both dgemm and sgemm because this tree is a bit old and uses some early practices of writing library tests. We should generally revamp the corresponding reframe test.

@vkarak vkarak changed the title Hpctestlib build both gpu dgemm+sgemm executables [testlib] Add support for build both GPU dgemm+sgemm executables Feb 2, 2022
@vkarak vkarak marked this pull request as ready for review February 2, 2022 14:59
@vkarak vkarak merged commit b04eae5 into reframe-hpc:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants