-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Remove runtime timings from the default output #2425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Should we also close #2415 with this? |
|
I think so, yes. |
victorusu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, I have a minor comment for improvement.
Codecov Report
@@ Coverage Diff @@
## master #2425 +/- ##
==========================================
- Coverage 85.67% 85.66% -0.01%
==========================================
Files 56 56
Lines 10466 10460 -6
==========================================
- Hits 8967 8961 -6
Misses 1499 1499
Continue to review full report at Codecov.
|
It might be better to remove the runtime timings from the default output, after the conversation in #2415 .
The documentation mentions that these timings correspond only to the ReFrame stages, but it can be misleading for new users that want to use them for performance monitoring.
Normal output:
Verbose output:
I still leave them in verbose mode, what do you think @vkarak ? If you agree I will change also all the reframe outputs in the docs.
Closes #2415.