[feat] Support for loggable variables, parameters and properties of tests #2428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 13, 2022 22:39
|
Hello @vkarak, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2022-02-18 10:48:44 UTC |
Codecov Report
@@ Coverage Diff @@
## master #2428 +/- ##
==========================================
+ Coverage 85.66% 85.69% +0.03%
==========================================
Files 56 56
Lines 10458 10510 +52
==========================================
+ Hits 8959 9007 +48
- Misses 1499 1503 +4
Continue to review full report at Codecov.
|
ekouts
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
loggableargument to thevariableandparameterinterface to allow you to mark a test variable or parameter as loggable. By default, no test attribute (variable or parameter) is loggable. This contrasts with the current default behaviour where everything is loggable, which can lead to problems, such as the one described in #2380. Test properties can also be logged by decorating them with either the@loggableor@loggable_asdecorators. A loggable attribute will become a log record attribute with the namecheck_NAME, whereNAMEis the name of the variable, parameter or property.Almost all previously loggable attributes of
RegressionTestandJobare also marked explicitly as loggable, except any attributes containing deferred expressions, such as thesanity_patternsand theperf_patterns. This PR breaks the logging of custom attributes that are not marked as loggable.This PR does not set the loggable attributes in the various library tests. A separate PR will follow for that.
Fixes #2380.