-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Update VASP checks and reference values #2454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2454 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 56 56
Lines 10536 10536
=======================================
Hits 9031 9031
Misses 1505 1505 Continue to review full report at Codecov.
|
|
I could not retrieve data for the multicore checks, because they have not been executed, as far as this warning is concerned: This pull request should fix the warning and run the check as expected. The same issue is also occurring with LAMMPS. |
|
Hello @lucamar, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2022-03-08 11:29:36 UTC |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm except a small bug updating the variables.
Co-authored-by: Vasileios Karakasis <vkarak@gmail.com>
I provide updated checks and reference values for VASP on Piz Daint after the upgrade: we will still need to monitor the performance over the next weeks, since I could not retrieve the data for the multicore check on Kibana.