Skip to content

Conversation

@lucamar
Copy link
Contributor

@lucamar lucamar commented Mar 1, 2022

I provide updated checks and reference values for VASP on Piz Daint after the upgrade: we will still need to monitor the performance over the next weeks, since I could not retrieve the data for the multicore check on Kibana.

@lucamar lucamar changed the title [test] Update VASP checks and refs [test] Update VASP checks and reference values Mar 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

Merging #2454 (aa7edcf) into master (7b27cbe) will not change coverage.
The diff coverage is n/a.

❗ Current head aa7edcf differs from pull request most recent head 4be3892. Consider uploading reports for the commit 4be3892 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2454   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files          56       56           
  Lines       10536    10536           
=======================================
  Hits         9031     9031           
  Misses       1505     1505           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b27cbe...4be3892. Read the comment docs.

@lucamar
Copy link
Contributor Author

lucamar commented Mar 1, 2022

I could not retrieve data for the multicore checks, because they have not been executed, as far as this warning is concerned:

./bin/reframe: skipping test 'VASPCpuCheck': attribute error: cscs-checks/apps/vasp/vasp_check.py:77: 'VASPCpuCheck' object has no attribute 'references_by_variant'

        self.reference = self.references_by_variant[self.variant]

This pull request should fix the warning and run the check as expected. The same issue is also occurring with LAMMPS.

@pep8speaks
Copy link

pep8speaks commented Mar 4, 2022

Hello @lucamar, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2022-03-08 11:29:36 UTC

@lucamar lucamar requested a review from vkarak March 7, 2022 11:41
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm except a small bug updating the variables.

@lucamar lucamar requested a review from vkarak March 8, 2022 09:52
@vkarak vkarak merged commit bbd552f into reframe-hpc:master Mar 8, 2022
@lucamar lucamar deleted the vasp_update branch March 8, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants